Strange plot points on curves from SVG conversion

sameer / svg2gcode

Convert vector graphics to g-code for pen plotters, laser engravers, and other CNC machines

https://sameer.github.io/svg2gcode

MIT License

254 stars 49 forks source link

Strange plot points on curves from SVG conversion #18

Closed Milner99 closed 3 years ago

Milner99 commented 3 years ago

happy dog svg and gcode.zip

Hi,

Attached is an SVG and GCode output from the online demo of svg2gcode. Seeing some strange plotted points near the head of the cartoon dog. Is this something going on in the SVG or the conversion?

Would love some advise and guidance please. thank you so much Chris.

sameer commented 3 years ago

Hi Chris,

Thank you for bringing this to my attention. Just pushed changes that fix the strange plot points:

g-code for Chris's image plotted showing that it is now correct

This was a miss on my part when refactoring svg2gcode to support circular interpolation.

Root cause: incorrect multiplication in control point tracking
Action taken:
- Correct the issue and push changes for that
- Add test cases using the provided image to ensure this particular use case does not see future regressions
- Making plans to test other edge cases based on coverage reports

sameer commented 3 years ago

I have confirmed that those changes have reached the web interface.

Thank you for using svg2gcode! Please let me know if you run into any other problems :slightly_smiling_face:

Milner99 commented 3 years ago

Wow, quick work. Thank you so much!