sameer / svg2gcode

Convert vector graphics to g-code for pen plotters, laser engravers, and other CNC machines
https://sameer.github.io/svg2gcode
MIT License
241 stars 48 forks source link

Offsets do not work anymore #25

Closed mtowara closed 2 years ago

mtowara commented 2 years ago

Specifying offests does not work for me. I remember it working, thus my guess would be that commit 00589256fbdfd73ec114232959b460ca0ba94f4c broke something.

Thanks for this awesome tool!

sameer commented 2 years ago

Hey Markus,

Thanks for bringing this up -- will take a look soon!

On Wed, Dec 8, 2021, at 12:24, Markus Towara wrote:

Specifying offests does not work for me. I remember it working, thus my guess would be that commit 0058925 broke something.

Thanks for this awesome tool!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sameer/svg2gcode/issues/25, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACUVICCRKOR4ND3WHJMUXPDUP6WGJANCNFSM5JUS4GHQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

sameer commented 2 years ago

Good eye, 0058925 was indeed the commit in question -- looks there's some more work to do before the bounding box logic is complete.