search

sameer / svg2gcode

Convert vector graphics to g-code for pen plotters, laser engravers, and other CNC machines
https://sameer.github.io/svg2gcode
MIT License
241 stars 48 forks source link

Support other non-closed, non-path elements #38

Closed sameer closed 5 months ago

sameer commented 1 year ago

32 pointed out that polylines don't work. Line should also work https://www.w3.org/TR/SVG11/shapes.html#LineElement

kvdveer commented 8 months ago

I've started work on this, I've written the code for rect, circle, ellipse, line, and polyline. I believe those are all the shapes from the spec.

Unfortunately I'm running into some problems with the coordinate system, I'm afraid I'll have to rework some of that according to SVG1.1 § 7. Do you prefer the coordinate rework as a separate MR, or as part of this one?

sameer commented 8 months ago

1 is fine, I appreciate you looking into this!

sameer commented 5 months ago

Fixed by 225574d34a7a180a68cac443711671845966149a