Closed sloev closed 3 years ago
Hey sloev,
I recently refactored the code I wrote for gcode parsing and I set the tool off action to be the tool on action. :man_facepalming:
Fix is pushed in a72ab62. I'll be looking into adding tests that cover these and other edge cases so it doesn't happen again
@sameer hey thanks for replying!!!
btw i fixed my situation by using a 3 line postprocessor that alternates between off/on, but having it in the tool is preferable!
bt the way here is something i was able to make thanks to your software!!! (thanks a bunch!)
btw i can help with creating a basic test suite if you want it @sameer ? it will take me no time
Sure, that would be helpful!
On Thu, Mar 4, 2021, at 07:32, sloev wrote:
btw i can help with creating a basic test suite if you want it @sameer https://github.com/sameer ? it will take me no time
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sameer/svg2gcode/issues/9#issuecomment-790584571, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACUVICHTQHQF2OF5YOFURCDTB54VNANCNFSM4YRNNCYQ.
I missed seeing that picture you shared when I replied by email :hushed: what does the SVG look like?
i am running the following command with one of the examples:
it generates the following gcode:
as you can see it does not include the "off" commands in its output, any idea why? @sameer btw: this little tool has singlehandedly gotten me to my first output so thanx a bunch!