sameeraroshan / visjs

visjs vaadin addon
Apache License 2.0
10 stars 13 forks source link

fireNodeSelectEvent is not called when deselecting a node #24

Open bmomani1 opened 6 years ago

bmomani1 commented 6 years ago

https://github.com/sameeraroshan/visjs/blob/a1fe860c48b7ce04a5baeca59670494977617878/src/main/java/org/vaadin/visjs/networkDiagram/NetworkDiagram.java#L368 is this the wanted behavior? I made a workaround to solve this issue by creating NodeDeselectEvent

@Override public void fireNodeSelectEvent(SelectEvent event) { if(!event.getNodeIds().isEmpty()) {// node select event does not fired on deselecting the node super.fireNodeSelectEvent(event); } else { this.fireNodeDeselectEvent(event); } }