evenbits
commented
9 years ago Maybe instead of having a listener per node it would be more convenient to have one listener per graph and figure out what to do by the nodeId inside event?
Open evenbits opened 9 years ago
evenbits
commented
9 years ago Maybe instead of having a listener per node it would be more convenient to have one listener per graph and figure out what to do by the nodeId inside event?
sameeraroshan
commented
9 years ago listener is indeed for graph. you can add nodes to the graph when the listener fires. may be you are trying to remove while iterating. for that copy objects to separate list and remove after the iteration. can you send me the code of that section.
On Tue, Mar 31, 2015 at 12:40 AM, Hans Peter Gundelwein < notifications@github.com> wrote:
Maybe instead of having a listener per node it would be more convenient to have one listener per graph and figure out what to do by the nodeId inside event?
— Reply to this email directly or view it on GitHub https://github.com/sameeraroshan/visjs/issues/7#issuecomment-87794917.
evenbits
commented
9 years ago No, I don't remove any nodes. I think the following code should make this more transparent.
public void setActiveData(ViewObject viewObject) {
if(viewObject != null) {
graphBuilder=new GraphBuilder(viewObject);
graphBuilder.build();
getNetworkGraph().clear();
getNetworkGraph().addNodes(graphBuilder.getNodes());
getNetworkGraph().addEdges(graphBuilder.getEdges());
registerListener(graphBuilder.getNodes());
} else {
getNetworkGraph().clear();
}
}
private void registerListener(List<Node> nodes) {
for(Node node : nodes) {
getNetworkGraph().addNodeSelectListener(new Node.NodeSelectListener(node) {
@Override
public void onFired(SelectEvent selectEvent) {
onSelect(selectEvent.getNodeIds());
}
});
}
}
private void onSelect(List<String> nodesId) {
for(String idStr : nodesId) {
ViewObject viewObject=findData(idStr);
if(isExpandable(viewObject)) {
graphBuilder.extend( viewObject);
for(Node extNode : graphBuilder.getExtendedNodes()) {
getNetworkGraph().addNode(extNode);
}
for(Edge extEdge : graphBuilder.getExtendedEdges()) {
getNetworkGraph().addEdge(extEdge);
}
registerListener(graphBuilder.getExtendedNodes());
Node graphNode=graphBuilder.findNode( node);
graphNode.setColor(expandedColor);
getNetworkGraph().updateNode(graphNode);
}
}
}
rafal-software
commented
9 years ago I have the same problem. java.util.ConcurrentModificationException The issue is that I want to adding nodes to graph by double click. Ive own widget for visjs network - I created my widget a few months ago. In my widget this effect its working, but I have some other problems...
Additional problem is that I have 3 edges for two nodes but I`m putting into edges collection only one edge for these nodes.
rafal-software
commented
9 years ago I`ve solved the problem in my local repository. Replacing ArrayList by java.util.concurrent.CopyOnWriteArrayList the line below:
private List<Node.NodeDoubleClickListener> nodeDoubleClickListeners = new CopyOnWriteArrayList();My suggestion is to replace all ArrayLists on this collection.
sameeraroshan
commented
9 years ago could you please provide me a sample code. I cannot recreate this issue.
Swoorup
commented
9 years ago I am encountering the same issue as well.
Swoorup
commented
9 years ago Can confirm that this fixes the issue albeit not sure if it has any drawbacks
private List
I need to modify a graph as a result of a click event. So I register a listener for reacting to this event by using
But if one of these listeners fires and within the same thread I add additional nodes to the graph and I (need? to) register additional listeners for these nodes, this results in a concurrentModificationException after the listener completes.