sameersbn / docker-apt-cacher-ng

Dockerfile to create a Docker container image for Apt-Cacher NG
MIT License
206 stars 71 forks source link

General Enhancement #40

Closed irish1986 closed 1 year ago

irish1986 commented 1 year ago

I have been using apt-cacher-ng for a while and notice a few improvement & enhancement could be made. I am submitting this PR and welcoming C&C.

Dockerfile

Dependabot

Pod Configuration

Build Workflow

Advanced Build Workflow I have added several steps in the build workflow, the goal is to create a temporary image for testing and scanning purpose before releasing the whole package. It is obviously slightly overkill for the purpose of this package but some useful best practices to learn and leverage.

irish1986 commented 1 year ago

Any chance we could look into this PR?

sameersbn commented 1 year ago

thanks for the contribution

sameersbn commented 1 year ago

@irish1986 would you be interested in the maintenance of this image?

irish1986 commented 1 year ago

@irish1986 would you be interested in the maintenance of this image?

It could be interesting, it's a fairly stable image with once in a while update. Would you be transferring the entirety of it ownership (gh, docker, etc,..) or simply adding me as a contribution owner?

sameersbn commented 1 year ago

i'll add you as an collaborator, so you would be able to merge PR's

irish1986 commented 1 year ago

i'll add you as an collaborator

Sounds good, I think there was a mistake in my latest PR which broke the pipeline. I'll take a look at this later given it hasn't impacted the current distributed image. I'll take a further look at the list of issue and see what i can do.

sameersbn commented 1 year ago

please accept my invitation. thanks for helping out.