search

sameersbn / docker-bind

Dockerize BIND DNS server with webmin for DNS administration
MIT License
919 stars 333 forks source link

Fix pod.yml definition which fails on kubernetes 1.16.2 #83

Closed sjmudd closed 4 years ago

sjmudd commented 5 years ago

Seen on microk8s:

$ kubectl apply -f pod.yml
Error from server (BadRequest): error when creating "pod.yml": Pod in version "v1" cannot be handled as a Pod: v1.Pod.Spec: v1.PodSpec.Containers: []v1.Container: v1.Container.Env: []v1.EnvVar: v1.EnvVar.Value: ReadString: expects " or n, but found f, error found in #10 byte of ...|,"value":false}],"im|..., bigger context ...|iners":[{"env":[{"name":"WEBMIN_ENABLED","value":false}],"image":"sameersbn/bind","name":"bind","por|...
$

Quoting false to "false" seems to work.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

sjmudd commented 4 years ago

not sure why this is marked as won't fix, just because it's stale? I can't push the change so marking it as stale is hardly my fault.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.