sameersbn / docker-gitlab-ci-multi-runner

MIT License
146 stars 86 forks source link

Docker in docker or simple docker features #26

Open digitalLumberjack opened 7 years ago

digitalLumberjack commented 7 years ago

Hi, first thank you for the great docker images you provide :)

According to https://docs.gitlab.com/ce/ci/docker/using_docker_build.html we can use docker to build our projects in gitlab runners.

Is this feature already available in your image ? I could not find it.

digitalLumberjack commented 7 years ago

https://github.com/sameersbn/docker-gitlab-ci-multi-runner/pull/29

sash commented 7 years ago

+1. Please merge this feature!

jameswalmsley commented 7 years ago

Hi @digitalLumberjack I have tried to use your docker-executor and have pulled from your docker hub images as well as building myself.

I cannot get this to work as I always see the following message when I attempt to build: GitlabCIMultiRunner_1 | WARNING: Checking for builds... failed runner=9db0911c status=500 Internal Server Error

Would you be able to tell me how to find out in more detail what is happening?

Thanks

James

digitalLumberjack commented 7 years ago

Hi dude :) Seems to be an issue while the runner is sending a request to your gitab server.

Do you have a self host gitlab CE ? did you try to add the runner on gitlab.com ?

I just runned it that way for gitlab.com and it works :

docker run -ti -v /var/run/docker.sock:/var/run/docker.sock --privileged -e "CI_SERVER_URL=https://gitlab.com/ci" -e "RUNNER_TOKEN=XXXXXXXX" -e "RUNNER_DESCRIPTION=digi" -e "RUNNER_EXECUTOR=docker" -e "RUNNER_DOCKER_IMAGE=docker:latest" -e "RUNNER_DOCKER_MODE=socket" digitallumberjack/docker-gitlab-ci-multi-runner:v1.9.3

See the url (it must finish by /ci)

jameswalmsley commented 7 years ago

I'm using nginx-proxy docker to sit many docker applications behind a single host. Maybe this is causing a problem.

I'll have a play around.

Thanks for the quick response.

James

jameswalmsley commented 7 years ago

I created a new project with a new ci script and it worked. Not sure what why its not working with the previous project, will get the other developer to take a look.

But great job and thanks for the work on supporting docker executors.