search

sameersbn / docker-gitlab-ci-multi-runner

MIT License
145 stars 85 forks source link

added docker executor support #29

Closed digitalLumberjack closed 7 years ago

digitalLumberjack commented 8 years ago

You can use the docker executor by using RUNNER_EXECUTOR=docker. You must provide a docker image to use in RUNNER_DOCKER_IMAGE (e.g. docker:latest)

If RUNNER_DOCKER_MODE is set to socket, the docker socket is shared between the runner and the build container. If it is not, you must use docker in docker service in your .gitlabci.yml definitions.

See https://docs.gitlab.com/ce/ci/docker/using_docker_build.html for more info.

djskinner-sky commented 7 years ago

This sounds good but I have to admit it's been a while since I've looked at this stuff. Would you mind letting me know if it supersedes this PR I created https://github.com/sameersbn/docker-gitlab-ci-multi-runner/pull/19. If so I'll close it.

djskinner commented 7 years ago

I'm using this on my own fork (combined with #31 for version 1.8.0) and it works great. Would be good to see it merged in.

oomathias commented 7 years ago

I'm referencing my fork here which support docker in docker, based on alpine, ENV_VARS support inside dind and support for rancher-compose.

There is a DNS change to support rancher-compose that will be removed when gitlab will supports docker labels. https://gitlab.com/gitlab-org/gitlab-ci-multi-runner/issues/1752

Link to the diff: https://github.com/sameersbn/docker-gitlab-ci-multi-runner/compare/39274ea7b0582ed0f3329e715aeaf80a4a43146e...oomathias:master