search

sameersbn / docker-gitlab-ci-runner

Dockerfile to build a base GitLab CI Runner container image.
MIT License
97 stars 37 forks source link

Zombie Processes #11

Closed zachaller closed 9 years ago

zachaller commented 9 years ago

We have a project that uses gunicorn and when gunicorn stops it like to rely on init process to clean up its parent processes. This leaves zombies behind. I think it would be a good idea to possible run something like supervisord as PID 1 so that it can take care of things like that.

sameersbn commented 9 years ago

@zachaller supervisord already runs as PID 1. If you start your processes using supervisor, then I think it will reap the dead processes.

zachaller commented 9 years ago

Ok so after I was just about to start looking into doing this myself I was going through the docker files and init scripts etc and I do see that it is there. The way I was running it before was from pulling from the docker repository instead of building it from the git repo so maybe that is worth looking into, or maybe it is just my noobness with docker that I am not understanding some difference between what is on the docker repo vs building myself.

zachaller commented 9 years ago

Going through the commits I see it just might be an old version on the docker repo

sameersbn commented 9 years ago

@zachaller do you mean old version of docker-gitlab-ci-runner image?

zachaller commented 9 years ago

Yea if you follow the readme and use

docker pull sameersbn/gitlab-ci-runner:5.0.0-1

sameersbn commented 9 years ago

@zachaller got it. I just released a new 5.0.0-2 release.