kkimurak
commented
4 months ago @th-2021 Could you provide more detail? Do you mean following error on using relative url enabled (that is said that can be safely ignored)?
Closed th-2021 closed 4 months ago
kkimurak
commented
4 months ago @th-2021 Could you provide more detail? Do you mean following error on using relative url enabled (that is said that can be safely ignored)?
th-2021
commented
4 months ago With relative url set. When I run the image I get make and g++ not found.
With make and g++ added I get:
kkimurak
commented
4 months ago Well, gcc and make are listed in BUILD_DEPENDENCIES in build script. They are purged at the end of the script.
We have some choise:
make and gcc on runtime only when GITLAB_RELATIVE_URL_ROOT is setmake and gcc at the end of build scriptThe second idea would be acceptable.
When I was working on preparing postgresl-13 (#2685), the initial idea for that pull request was to install the appropriate version of postgresql-client at runtime. After receiving a review from the maintainer @sachilles saying that he wanted to avoid requiring an internet connection, I rewrote the patch to pre-install a possible version of postgresql-client in the image. It has been merged.
This may be pointless since we (relative url users) install the necessary node modules at runtime anyway, but I'll write this as advice anyway. I means that I have no plans to create a pull request on this subject at this time.
th-2021
commented
4 months ago I tried the upgrades again and the error can be ignored. With one version I had broken assets and thought that this is the issue, but it must have been something different. It worked now.
shplishka
commented
4 months ago Is there any version where this doesn't happen?
kkimurak
commented
4 months ago @shplishka No. More precisely, the root cause of this problem (a situation where gcc and make are required at runtime) is not known. According to @th-2021 's report, it may be caused by corrupted assets but not clear.
I've been running gitlab with the relative url feature enabled in all versions since at least 13.10.3 until 17.2.0 (latest version available today), and no such situation occurred on my environment.
If you are facing similar issue, providing your detailed setup may help someone who interested in this topic to debug.
th-2021
commented
4 months ago I think my issue with broken assets was unrelated to the node modulesAm 24.07.2024 11:10 schrieb Kazunori Kimura @.***>: @shplishka No. More precisely, the root cause of this problem (a situation where gcc and make are required at runtime) is not known. According to @th-2021 's report, it may be caused by corrupted assets but not clear. I've been running gitlab with the relative url feature enabled in all versions since at least 13.10.3 until 17.2.0 (latest version available today), and no such situation occurred on my environment. If you are facing similar issue, providing your detailed setup may help someone who interested in this topic to debug.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>
shplishka
commented
4 months ago Hi @th-2021 and @kkimurak,
Thank you for your previous assistance. I am facing another problem related to this behavior. When I use a relative URL in an air-gapped cluster that doesn't have access to npm, Artifactory, etc., the image crashes when it tries to install the node modules.
I'm not sure how to resolve this issue. Any advice would be appreciated.
kkimurak
commented
4 months ago @shplishka
Unfortunately, the relative URL feature should not work without an active internet connection - as this image, sameersbn/gitlab, is published with node_modules removed at the end of build to reduce image size.
Anyway, could you create a new issue about it (relative url does not work if there is no access to npm registry and so on) ? I think it's not a good idea to continue discussing on an issue that has already been closed, and I think it's different from what was originally reported for this issue.
Submitting a merge request is much better. You should just modify the line.
diff --git a/assets/build/install.sh b/assets/build/install.sh
index 47fc4620..fb330b23 100755
--- a/assets/build/install.sh
+++ b/assets/build/install.sh
@@ -484,5 +484,5 @@ rm -rf /var/lib/apt/lists/*
# clean up caches
rm -rf ${GITLAB_HOME}/.cache ${GITLAB_HOME}/.bundle ${GITLAB_HOME}/go
-rm -rf /root/.cache /root/.bundle ${GITLAB_HOME}/gitlab/node_modules
+rm -rf /root/.cache /root/.bundle
rm -r /tmp/*I can report how much the image size changes.
In any case, the maintainer will make the final decision. You can mention to active maintainer (@sachilles) on demand.
During assets compile I get error that some node modules are missing. This is with all newer versions e.g. 17.0.3