healthcheck not works - Githubissues

sameersbn / docker-gitlab

Dockerized GitLab

http://www.damagehead.com/docker-gitlab/

MIT License

7.87k stars 2.14k forks source link

healthcheck not works #2992

Open GordonHuangYong opened 2 weeks ago

GordonHuangYong commented 2 weeks ago

run

curl http://localhost/-/liveness

response

{"error":"Not Found","status":404}

run

curl http://127.0.0.1/-/liveness

response

{"status":"ok"}

GordonHuangYong commented 2 weeks ago

i modify the file /usr/local/sbin/healthcheck

#!/bin/bash
url=http://127.0.0.1/-/liveness
options=( '--insecure' '--location' '--silent' )
curl "${options[@]}" $url

kkimurak commented 2 weeks ago

Hi @GordonHuangYong , thank you for reporting. As also reported in a part of #2766, current healthcheck script uses localhost and it is resolved to ::1 (IPv6 loopback address) that is not listed in monitoring IP whitelist by default.

The author of #2766 clearly described the root cause and fix then asked, "are you interested in a PR". The maintainer respond, "Feel free to provide an PR". So I thought that if I waited a while, a pull request would be submitted. However, none of the proposed fixes have been submitted as pull requests at this time.

Can you create a pull request to fix this issue? Or should I do it?

GordonHuangYong commented 2 weeks ago

Thanks for the invitation but No PR. not good at writing in english and coding