search

sameersbn / docker-gitlab

Dockerized GitLab
http://www.damagehead.com/docker-gitlab/
MIT License
7.87k stars 2.14k forks source link

v17.4.1 postgresql-client-16 is missing #3015

Open fidoedidoe opened 2 days ago

fidoedidoe commented 2 days ago

while testing a non-production upgrade from version v17.3.1 -> 17.4.1 I can see the postgresql-client-16 is no longer present. The log output being: 

...
Configuring /home/git/.postgresqlrc to avoid version mismatch on dumping
- Detected server version: 160004
gitlab_generate_postgresqlrc(): WARNING - Suitable client not installed. postgresql-client-17 will be used but you may face issue (database in backup will be empty, for example)
- Generating /home/git/.postgresqlrc
17 myhostname:8432 gitlab
- Uninstalling unused client(s): postgresql-client-13 postgresql-client-14 postgresql-client-15
...

The Official GitLab documentation (link), reads: 

First GitLab version | PostgreSQL versions | Default version for fresh installs | Default version for upgrades | Notes
17.4.0               | 14.11, 16.4         | 14.11                              |14.11                         |PostgreSQL 16 is available for new installations

Am I mistaken, or should the postgresql-client-16 be included?

kkimurak commented 2 days ago

Good point, it should be added to Dockerfile and README.md.

Do you have plan to submit a PR? Or should I do that?

fidoedidoe commented 1 day ago

Good point, it should be added to Dockerfile and README.md.

Do you have plan to submit a PR? Or should I do that?

a PR is probably beyond my skill level, if you (or someone else with greater skill than I) is open to creating a PR it would be very much appreciated!!

kkimurak commented 10 hours ago

@fidoedidoe Done - see #3017. Thank you for your report!