sameersbn / docker-invoiceplane

Dockerfile to create a Docker container image for InvoicePlane
MIT License
45 stars 51 forks source link

update to version 1.5.3 #13

Closed chegel closed 6 years ago

chegel commented 7 years ago

update to version 1.5.3

added "php${PHP_VERSION}-curl" to Dockerfile because of error: ... Installing dependencies from lock file Your requirements could not be resolved to an installable set of packages. Problem 1

added nodejs (npm, grunt-cli) in order to compile /assets from sources

added nano for editing ipconfig.php

make a copy of ipconfig.php and set writable permissions

chegel commented 7 years ago

The only configuration step required is to edit and set InvoicePlane url. Start containers: docker-compose up Login to docker invoiceplane container (docker ps for list of running container names): docker exec -it dockerinvoiceplane153_invoiceplane_1 bash edit ipconfig.php nano ipconfig.php IP_URL=http://localhost:10080 restart docker-compose: docker-compose up --no-recreate

ihr-it-projekt commented 6 years ago

please merge this changes

j3k0 commented 6 years ago

@chegel Did you publish this on docker hub? (didn't find it)

chegel commented 6 years ago

I did not publish on docker hub, I am ok with sameersbn/docker-invoiceplane project. Why to create another branch? It looks like I don't have permissions to merge this pull request to master (sameersbn/docker-invoiceplane project).

j3k0 commented 6 years ago

It'd be better if we could all keep using @sameersbn / docker-invoiceplane. But after 3 months it seems like he wouldn't merge this update, so it might be worth creating an alternative (hopefully temporary) automated build for people to use...

sameersbn commented 6 years ago

hi. working on merging this

sameersbn commented 6 years ago

Hey @chegel are you able to use the download PDF option?

chegel commented 6 years ago

No

sameersbn commented 6 years ago

I've merged this PR into #15 and worked on fixing some of the issues. Please refer to the referenced PR for further discussion. This PR will be closed when #15 is merged