sameersbn / docker-wowza

Dockerfile to containerize Wowza Streaming Engine
MIT License
64 stars 42 forks source link

Upgrade to Wowza 4.3.0 #10

Closed mtneug closed 8 years ago

mtneug commented 8 years ago

Looking for solutions for issue #6, I came across ansible-wowza which uses expect to interact with the installer. After some changes to the expect script I ended up with interaction.exp.

On problem still remains thou. The installer expects a "real" license key, i.e. send -- "xxxxx-xxxxx-xxxxx-xxxxx-xxxxx-xxxxx-xxxxxxxxxxxx\r" in line 15 will not work. However you probably should be able to use an old developer key. I was able to continue the installation with this key. Note that Server.license is removed so that no Wowza Engine is started with that key.

mtneug commented 8 years ago

Should I resolve conflicts and add a developer key or do you think this is a bad approach?

sameersbn commented 8 years ago

@mtneug I have no issues with the approach, Earlier I was also considering using expect to perform the installation. But since the installer required a key for the install to happen I did not do it.

My concern really is with the publicly visible key. I am not sure how wowza media would feel about this and/or whether the wowza EULA allows users to expose their license key like the one you linked to in your previous comment. It sure is an expired key, but still. I have been contacted by their lawyer on a previous occasion, but this might be crossing the line. What are your thought on this?

One possible workaround is installing wowza at runtime with a user specified license key. This will obviously effect the startup time of the container but at least it will make the image usable with the new wowza versions.

mtneug commented 8 years ago

While I'm not sure if it is against the EULA (at least some sections read like that), it's probably best to be on the safe side.

Installing Wowza at runtime seems fine to me. I don't mind the longer startup time. I will try to implement it this week. For that would you prefer to download the Wowza installer during image build or at runtime, i.e. size vs. startup time?

sameersbn commented 8 years ago

I will try to implement it this week

Thanks for your efforts.

For that would you prefer to download the Wowza installer during image build or at runtime, i.e. size vs. startup time?

Pre-downloaded installer at build time should be fine I think.

There is one other possible option. If we can configure a CI server to install wowza using expect and then tar all the installed components and make the tarball available as a build artifact, then we could use that tarball as the install package with this image. I think should be able to protect the license key used while installing the package using private CI variables. I have not tried this sort of thing before, but should definitely be possible. In the wowza forums I remember this being suggested by one of the support people for an unattended install.

sameersbn commented 8 years ago

There is one other possible option. If we can configure a CI server to install wowza using expect and then tar all the installed components and make the tarball available as a build artifact, then we could use that tarball as the install package with this image. I think should be able to protect the license key used while installing the package using private CI variables. I have not tried this sort of thing before, but should definitely be possible. In the wowza forums I remember this being suggested by one of the support people for an unattended install.

scratch that, lets stay out of trouble.

mtneug commented 8 years ago

OK, installation is now done during container start. I moved the license check before the installation, as it is there where this question is asked originally.

sameersbn commented 8 years ago

@mtneug will review/test and merge

sameersbn commented 8 years ago

@mtneug have merged the PR. However I reverted the version number changes in the README and other places to 4.1.2-8 until a new release is tagged. The changes made by this PR will be available in the latest tag.

Holding back on a new tag to allow some more time to test the changes and/or make improvements.

mtneug commented 8 years ago

Thanks for the merge :smiley: