samehuman / cld2

Automatically exported from code.google.com/p/cld2
0 stars 0 forks source link

Add armv8-a support #34

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
On behalf of Milton.Chiang@mediatek.com (cc'd):

--- snip ---
I would like to send a patch to CLD_2 for adding ARMv8a to the supporting list 
in internal/port.h.
It’s my first time to send patches to CLD_2 project, and I have no idea how 
to upload it.

Can you take a look at the attached file to check if this modification is 
useful? Is there any issue related to this modification? Also, can you tell me 
how to upload the patch properly?

Thanks for your kindly help.
--- snip ---

Original issue reported on code.google.com by andrewha...@google.com on 5 May 2015 at 9:46

Attachments:

GoogleCodeExporter commented 9 years ago
Hi Milton,

Thanks for the patch. This is the right process, just file an issue here in the 
CLD2 project and attach a patch file like you did. We'll take a look and get 
back to you.

Looks straightforward, I think the primary concern will be testing it on some 
real producion ARM v8-a hardware so that we can verify that the instruction 
alignment stuff (and so on) works properly there and doesn't crash.

Jason Riesa (riesa@google.com, cc'd) is the current maintainer of the overall 
project, I usually handle stuff for dynamic data loading and Chromium 
integration.

Original comment by andrewha...@google.com on 5 May 2015 at 9:50

GoogleCodeExporter commented 9 years ago
This looks fine to me. Who can test it on an ARM v8 chip? /dick

Original comment by dsi...@google.com on 5 May 2015 at 10:07

GoogleCodeExporter commented 9 years ago
@#2 Milton can test on his ARMv8-A chip. And/or I can help route ARMv8-A 
hardware to whomever would like to verify.

Original comment by djku...@chromium.org on 12 May 2015 at 2:28