samelhousseini / km-openai

MIT License
56 stars 99 forks source link

Issue with location of the Server Farm #2

Closed amantaras closed 1 year ago

amantaras commented 1 year ago

hello team,

there is an issue with the template. If you choose a different location than westerneurope the deployment fails because the serverFarm has location harcoded to West Europe:

original template:

image

I forked the repo and I have replaced "West Europe" with

[parameters('NewOpenAIResourceLocation')]

so that now it uses always the same location.

amantaras commented 1 year ago

I have requested a pull request with the change

samelhousseini commented 1 year ago

Hi Augustin,

Yes Aadrika has already notified me, and I've fixed it probably 20 minutes ago.

Many thanks for letting me know as well.

Samer


From: Agustin Mantaras @.> Sent: Tuesday, March 14, 2023 3:33 PM To: samelhousseini/km-openai @.> Cc: Subscribed @.***> Subject: [samelhousseini/km-openai] Issue with location of the Server Farm (Issue #2)

hello team,

there is an issue with the template. If you choose a different location than westerneurope the deployment fails because the serverFarm has location harcoded to West Europe:

original template:

[image]https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F41587804%2F224988030-356af1ad-24f9-40ab-af4e-6c22f92974e3.png&data=05%7C01%7Csamer.elhousseini%40microsoft.com%7C0487290fc4f646a71c9508db247ff37b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638143904211143545%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=MoNGtr8Gvsa7fJN88pGzMBm7%2BKDwi0uSVtjtrNororQ%3D&reserved=0

I forked the repo and I have replaced "West Europe" with

[parameters('NewOpenAIResourceLocation')]

so that now it uses always the same location.

— Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsamelhousseini%2Fkm-openai%2Fissues%2F2&data=05%7C01%7Csamer.elhousseini%40microsoft.com%7C0487290fc4f646a71c9508db247ff37b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638143904211143545%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ZgWXj6IOH5RzefdL6GZlvjE49OVhNN9jHzsoKw6oVUo%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAZ2RAUTYLSTGW5IXANJGJVTW4BJRBANCNFSM6AAAAAAV2KDLUQ&data=05%7C01%7Csamer.elhousseini%40microsoft.com%7C0487290fc4f646a71c9508db247ff37b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638143904211143545%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=5LaQ68tfwNzkXWvEXaa85cx%2FBbDhDpUfNmN3h7wl5lQ%3D&reserved=0. You are receiving this because you are subscribed to this thread.Message ID: @.***>

samelhousseini commented 1 year ago

Fixed.