samelhousseini / km-openai

MIT License
56 stars 99 forks source link

Fixing the imports problem - added cosmos_helpers #6

Open vykhand opened 1 year ago

vykhand commented 1 year ago

Hey Samer, I see that you removed cosmos_helpers in the commit from yesterday, and as of 27.03 it was still there :) I hit this issue because I specified the non-existing base model, and it hit the OldSchoolSearch.py, and failed with missing import. BTW after adding the import back, it went into an infinite loop when the base model was not correct, and I could not debug why, may be it is also fixed. So, feel free to discard this PR

samelhousseini commented 1 year ago

Hey Andrey,

I think I've done lots of "bug hunting" in the last few days, so I hope that all is fixed now :) let me know if you face any further issues.

One thing that you might also want to do, is to flush Redis and re-ingest all data, because I've made changes to the Redis metadata schema on Monday I think. So if you hit any weird errors, this is something to try.

Please feel free to reach out any time.

Samer


From: Andrey Vykhodtsev @.> Sent: Thursday, March 30, 2023 7:22 PM To: samelhousseini/km-openai @.> Cc: Samer El Housseini @.>; Comment @.> Subject: Re: [samelhousseini/km-openai] Fixing the imports problem - added cosmos_helpers (PR #6)

Hey Samer, I see that you removed cosmos_helpers in the commit from yesterda, and as of 27.03 it was still there :) I hit this issue because I specified the non-existing base model, and it hit the OldSchoolSearch.py, and failed with missing import. BTW after adding the import back, it went into an infinite loop when the base model was not correct, and I could not debug why, may be it is also fixed.

— Reply to this email directly, view it on GitHubhttps://github.com/samelhousseini/km-openai/pull/6#issuecomment-1490496318, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZ2RAUTMPBC6GU4RTGDUXLTW6WQLPANCNFSM6AAAAAAWHCTAOY. You are receiving this because you commented.Message ID: @.***>