Possible fix for T8420 camera

[fullphat]

Specifically, the HomeKit Alarm System created for the camera not responding to changes in the Eufy app

[schliemann]

I need some time to verify the change.

[fullphat]

I need some time to verify the change.

That's fine! This is my first foray into git PRs and branches, and my first foray into Javascript, node and HomeBridge plugin development so I may well have got many things wrong! 😊 Just let me know if you have any queries. 👍🏼

[fullphat]

For info, the T8420 does support the ability to arm, disarm, schedule and geo-fence and you can enable any of motion detection, push notifications and siren for the home or away modes:

So having it as an Alarm System is HomeKit is really helpful. One thing I have spotted as well is that when the plugin starts, there is a log message along the lines of "Device is station but type is 3 might imply errors".

[lenoxys]

So having it as an Alarm System is HomeKit is really helpful. One thing I have spotted as well is that when the plugin starts, there is a log message along the lines of "Device is station but type is 3 might imply errors".

This is normal behavior to have this log message. Camera act as a station but doesn't have all station capabilities. That's why you get the warning message.

Btw, did you have a look on my comment on your PR ?

https://github.com/samemory/homebridge-eufy-security/pull/326#pullrequestreview-849121206

[fullphat]

So having it as an Alarm System is HomeKit is really helpful. One thing I have spotted as well is that when the plugin starts, there is a log message along the lines of "Device is station but type is 3 might imply errors".

This is normal behavior to have this log message. Camera act as a station but doesn't have all station capabilities. That's why you get the warning message.

That's fine.

Btw, did you have a look on my comment on your PR ?

#326 (review)

Apologies - I can't find it?

[schliemann]

@fullphat I'll take a look at this PR when I have pushed the changes to snapshot to the beta.

[lenoxys]

• Could you not point to a specific model while naming this function?
  • It would rather inverse have isAlarmStation than isFloodlight and avoid creating the object
  • Escape it like this if (!isAlarmStation()){ this.log.debug('does not provide alarm capabilities') return; }

[fullphat]

• isAlarmStation

Could you not point to a specific model while naming this function?

• It would rather inverse have isAlarmStation than isFloodlight and avoid creating the object
• Escape it like this if (!isAlarmStation()){ this.log.debug('does not provide alarm capabilities') return; }

Yes, I can do - is isAlarmStation() already defined somewhere? If not, how do I test if something is an alarm station?

Don't forget that the floodlight camera does provide an alarm function; it's more that it's its own station.

[fullphat]

• isAlarmStation

Could you not point to a specific model while naming this function?

• It would rather inverse have isAlarmStation than isFloodlight and avoid creating the object
• Escape it like this if (!isAlarmStation()){ this.log.debug('does not provide alarm capabilities') return; }

Yes, I can do - is isAlarmStation() already defined somewhere? If not, how do I test if something is an alarm station?

Don't forget that the floodlight camera does provide an alarm function; it's more that it's its own station.

[github-actions[bot]]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

[schliemann]

@fullphat Has this been fixed by some of @karesake fixes?

[fullphat]

@fullphat Has this been fixed by some of @karesake fixes?

I think it might have been but I haven't been able to check it properly yet. Give me a couple of days to confirm?

Using the Home app to change alarm state

Off - works and reflected in Eufy app Home - works and reflected in Eufy app Away - works and reflected in Eufy app Night - Home app stuck on "Arming..." until I leave the app and return to it when it reverts back to whatever state it was previously at.

[github-actions[bot]]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

[github-actions[bot]]

We do not accept PR on this repo. Please submit your issue on this repo : https://github.com/homebridge-eufy-security/plugin/pulls, thanks. If you have any questions, please feel free to contact us.