samerton / NamelessMC

A complete Minecraft-related PHP website package. Please note this is an old repository, a link to the new repo is in the readme
https://github.com/NamelessMC/Nameless
MIT License
39 stars 17 forks source link

Registering with non valid Minecraft Username #64

Closed Bob1nz closed 9 years ago

Bob1nz commented 9 years ago

Is there a plan to add a check that a Minecraft Username is valid? I was able to register using a non valid name which results in the user not being able to access their profile as the Column 'uuid' cannot be null.

samerton commented 9 years ago

Unable to reproduce this issue, currently all usernames must be valid Minecraft accounts; if not, the registration won't be successful. How were you able to register using a non valid name?

Bob1nz commented 9 years ago

I was able to register with the username "harry potter" It created the account and obviously could not get the uuid. I will try it again and see if I can provide some more information.

Bob1nz commented 9 years ago

I have made a short clip showing what I did to register with a non valid name. https://drive.google.com/file/d/0ByxnSCB19PNlV09EVi1mTERwRDQ/view?usp=sharing

samerton commented 9 years ago

I'm able to reproduce now, the issue seems to occur when there's a space in the username. Pushing a fix now.