Closed RaphaelRobidas closed 11 months ago
This looks like a neat trick! Can you make your pull request to the develop
branch, and not master
? See: DEVELOPERS.rst.
edit: also, let me know if you see GitHub Actions running code checks when you make a pull request to develop
. If not, I may need to tweak them.
Sorry, it looks like I missed that info!
It looks like no Github Action was triggered. There isn't a "on pull request" trigger in the actions currently.
A test in Jupyter with %%timeit didn't show a real speed boost, but I think your solution is more elegant, so let's do this.
A small tweak the
_transition_matrix_dense
seems to increase its speed twofold.Original code (
nspins=8
):_transition_matrix_dense took 33.4841s for 10000 runs
New code:
_transition_matrix_dense took 16.7938s for 10000 runs
The equivalence has been verified for good measure as such: