search

sametz / nmrsim

A Python library for NMR simulation
MIT License
21 stars 6 forks source link

Sparse v0.11.0 breaks nmrsim.qm #8

Closed sametz closed 3 years ago

sametz commented 3 years ago

Minimal bug report for now to alert users that sparse 0.11.0 broke the Hamiltonian calculations in nmrsim.qm. It appears to be typing-related. For now, pin your sparse version to <=0.10

sametz commented 3 years ago

Update: there seemed to be related issues posted over on the Sparse GitHub. They were supposedly fixed in sparse 0.12.0. However, nmrsim does not work with that update either.

sametz commented 3 years ago

Temporary fix with release 0.5.2 pinning sparse to <=0.10.0. Waiting on resolution to sparse issue #499, as well as issue #493.

sametz commented 1 year ago

The issue was fixed with sparse 0.13.0. See: https://github.com/pydata/sparse/commit/b132b68f32bc6562f809b8bcfb09235965720d22

The next update to nmrsim should allow sparse >=13 as a requirement as well as <=10.