samfundev / KtaneTwitchPlays

A mod that allows Twitch chat to solve bombs in KTANE.
MIT License
46 stars 38 forks source link

allow calling a module without ! in front of the ID #615

Closed red031000 closed 1 year ago

KScl commented 1 year ago

Personally I'd prefer requiring the ! so it's clear you're trying to call a specific module by its ID. Calling a named queued command for the module called '7' and calling an unnamed command for the module with the ID 7 are otherwise ambiguous, and I can foresee that tripping someone up.

red031000 commented 1 year ago

named queue commands take precidence, but if it makes more sense to have the explicit exclamation point, that's fair

samfundev commented 1 year ago

I don't like the fact that you could use '7' expecting it to call module 7 but there is actually something named that, so it calls the wrong command. I feel like keeping it explicit would be better.