search

samg / timetrap

Simple command line timetracker
http://rubygems.org/gems/timetrap
Other
1.48k stars 115 forks source link

Add system editor feature #130

Closed patrickdavey closed 8 years ago

patrickdavey commented 8 years ago

Hi Sam,

I've created the basic functionality to use the system editor. I've only tested locally (using vim) and it seems to work fine.

I haven't added tests yet as I'm not really sure how best to mock out the use of an external editor. I could just call out to a method which will create the tempfile etc. and then stub it in tests. Happy to implement that / whatever else you like.

Anyway, let me know if this is what you're after, and thanks for a great gem.

Fixes #101

patrickdavey commented 8 years ago

Closing this for the moment. I want to check in other system editors and also fix up my use of the IO.read line.