search

samg / timetrap

Simple command line timetracker
http://rubygems.org/gems/timetrap
Other
1.48k stars 115 forks source link

Set start of week #141

Closed namdnguyen closed 7 years ago

namdnguyen commented 7 years ago

It would be useful to be able to set what day starts the week for t week. Monday appears to be the default, but allowing a configuration variable like week_start: Sunday in the .timetrap.yml file would be great.

samg commented 7 years ago

Sounds like a good improvement. It would be pretty easy to hook this into the config system so the Monday default could be overridden.

namdnguyen commented 7 years ago

Hey @samg. Hopefully, you haven't already worked on this. I thought I would take a stab at this as my first contribution to an open source project. It did seem to be pretty easy, as you mentioned. I'll submit a pull request soon, if you could still use it.

samg commented 7 years ago

Sounds great. Thanks!

On Saturday, September 24, 2016, namdnguyen notifications@github.com wrote:

Hey @samg https://github.com/samg. Hopefully, you haven't already worked on this. I thought I would take a stab at this as my first contribution to an open source project. It did seem to be pretty easy, as you mentioned. I'll submit a pull request soon, if you could still use it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/samg/timetrap/issues/141#issuecomment-249395166, or mute the thread https://github.com/notifications/unsubscribe-auth/AABWhPtbf8kjgkkmHQJAprY06j4nCa-oks5qtb_IgaJpZM4J9QKo .

namdnguyen commented 7 years ago

I'll be submitting the pull request from my fork, but I had a question about squash merging. It seems like you are using squash merging or your collaborators are squashing when they submit. I don't have any interesting history with this, anyways, just typo fixes and testing.

Should I squash my history in this feature branch (set_week_start) before submitting the pull request or can I submit the branch to you and you'll be able to squash merge it into the master branch?

samg commented 7 years ago

I don't have any strong preference about how the commits are structured or squashed.

On Tue, Sep 27, 2016 at 1:08 AM, namdnguyen notifications@github.com wrote:

I'll be submitting the pull request from my fork, but I had a question about squash merging. It seems like you are using squash merging or your collaborators are squashing when they submit. I don't have any interesting history with this, anyways, just typo fixes and testing.

Should I squash my history in this feature branch (set_week_start) or can I submit the branch to you and you'll be able to squash merge it into the master branch?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/samg/timetrap/issues/141#issuecomment-249795521, or mute the thread https://github.com/notifications/unsubscribe-auth/AABWhEXKYPoEhDE_SvLVRcBIXZpL2vGoks5quM76gaJpZM4J9QKo .