search

samg / timetrap

Simple command line timetracker
http://rubygems.org/gems/timetrap
Other
1.48k stars 115 forks source link

Update sequel dependency to version 4.4.0 #156

Closed rubik closed 4 years ago

rubik commented 7 years ago

In Ruby 2.4.0, the old version of sequel gives annoying warnings about Fixnum and Bignum, which in the newer version of Ruby were unified into Integer:

$ t s
/home/user/.gem/ruby/2.4.0/gems/sequel-4.0.0/lib/sequel/database/schema_generator.rb:19: warning: constant ::Fixnum is deprecated
/home/user/.gem/ruby/2.4.0/gems/sequel-4.0.0/lib/sequel/database/schema_generator.rb:19: warning: constant ::Bignum is deprecated
 Timesheet      Running     Today       Total Time
 [...]

The last version of sequel fixes these.

dashkb commented 7 years ago

lol https://github.com/samg/timetrap/pull/155... @samg isn't ultra-responsive

jostber commented 6 years ago

Sequel is regularily updated, now in version 5.0.0. What about leaving this version dependency open so timetrap works with all versions?

jostber commented 6 years ago

Any news on this? I am packing timetrap for SlackBuild and the old sequel dependency gives a run error.

dashkb commented 6 years ago

Sounds like a good idea; I'd suggest opening the PR so if @samg thinks it's a good idea he can just merge it.

berkes commented 4 years ago

I've updated all dependencies and fixed the issues from that in https://github.com/samg/timetrap/pull/180