search

samg / timetrap

Simple command line timetracker
http://rubygems.org/gems/timetrap
Other
1.48k stars 116 forks source link

How come notes can only be added when checking in? #170

Open josephfarina opened 6 years ago

josephfarina commented 6 years ago

Hello,

I am just curious if there is a way to require notes when checking out rather than in? In the documentation it seems like this is an in only feature?

Sorry if this is an obvious question and I am missing something.

Thanks!

fiveNinePlusR commented 5 years ago

looks like you can use the edit command to add notes to a particular id. t edit --append "some note" or t edit --id xyz --append "some note" use t display -v to see the ids

dechimp commented 4 years ago

To me, this is a good point. Often, I don't have an official idea of what to note until after I'm finished with my task. I personally use t edit "I did this", but it would be nice to combine this into t out.

Currently if you try the same syntax for in, it assumes you want to clock out of a different sheet:

t out "I worked hard"
Can't find sheet matching "I worked hard"

neither does this work:

t out --append "i worked hard"
Can't find sheet matching "I worked hard"

I wouldn't want to disrupt anyone's workflow (if they actually use t out myOtherTimeSheet), but on the other hand, in does not behave the same way. t in myOtherTimesheet clocks in to the current timesheet and creates a note of "myOtherTimesheet".

I would like to throw out two options, which I would I would be happy to try to make a PR for:

A. Change out to behave more like in and edit. So t out I worked hard would clock out of the current sheet and replace the note.

B. Create a --note flag for most commands. So clocking out with a note would look something like t out --note I worked hard.

Or perhaps make both possible. Any thoughts?

dechimp commented 4 years ago

Related: #16

johan162 commented 3 years ago

I too belive consistency between in/out would be a great UI improvement. In addition adding a config "require_note_out" to specify whether a not is needed at checkout or not would be good idea to mirror the "require_note" at checkin.

For me it also makes more sense to at least have the option of adding a message at checkout (kind of mirroring the way you use -m with git afte making a change).

If a note is added both at checkin and checkout the checkout note should just be appended.