search

samg / timetrap

Simple command line timetracker
http://rubygems.org/gems/timetrap
Other
1.48k stars 116 forks source link

Require note config #81

Closed TSFoster closed 10 years ago

TSFoster commented 10 years ago

Hey,

I added this to my build, because I want to add a note to everything I do (useful for when clients ask how I spent my time), but I'm really bad at remembering to write one.

If this is something you think would be worth pulling, I'll add spec and documentation first.

P.S. It'd really make most sense in cli.rb but I put it in timer.rb so it raises AlreadyRunning before asking for a note.

samg commented 10 years ago

This is a cool idea.

I have a few comments on the diff that I'll put inline there. I'm thinking it's probably okay to put this logic in Timer.start.

Also you should add some tests to cover this behavior so it won't be broken by future changes.

Thanks!

samg commented 10 years ago

I had a bit of extra time tonight and just pushed a version of this feature out in version 1.8.12. Thanks for the contribution.