Might be considered a defect - handling of CRCs

[GoogleCodeExporter]

When handling a CRC value with a leading zero, that zero is truncated. For 
instance, "0F870806" becomes "F870806".

This is not necessarily a defect, but it is common to refer to the full 8 
character CRC, and thus this results in mismatches. 

It might be worth searching for both strings (i.e. the search you're doing 
already and one padded out with zeros) 

Original issue reported on code.google.com by vey...@gmail.com on 16 Jul 2010 at 10:49

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

I think this will solve it: cast into integers for the comparison (dbupdate.py)

for resultcrc in resultcrcs:
    self.log("crc in parsed result: " +resultcrc, util.LOG_LEVEL_DEBUG) 
    if(int(resultcrc.lower(),16) == int(filecrc.lower(),16))

Original comment by vey...@gmail.com on 20 Jul 2010 at 3:09

[GoogleCodeExporter]

Oh, sorry. I did not see that you added issues here. Something went wrong with 
the email notification. 

I am quite sure that I already fixed this problem in one of the preview V0.6 
versions. Have a look at the download page and switch to "All downloads". The 
latest (V0.6h) should be a good one. It is a nearly feature complete V0.6 but 
not fully tested and documented. Maybe you have to import your games again if 
you currently use V0.5.

Original comment by maloep on 31 Jul 2010 at 7:10

[GoogleCodeExporter]

Original comment by maloep on 31 Jul 2010 at 7:11

• Changed state: Done
• Added labels: Type-Defect
• Removed labels: Type-Enhancement

[GoogleCodeExporter]

Original comment by maloep on 21 Nov 2013 at 6:54

• Changed state: Fixed