samheg / romcollectionbrowser

Automatically exported from code.google.com/p/romcollectionbrowser
GNU General Public License v2.0
0 stars 0 forks source link

Do not use a command shell to launch programs / minimize it #85

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Currently a command shell ("dos" box) pops up when a game is launched. It is 
also visible when the emulator exits. Either launch the application directly 
without this, or if not possible start it minimized. Cosmetic enhancement.

Original issue reported on code.google.com by desktop...@gmail.com on 26 Jul 2011 at 6:44

GoogleCodeExporter commented 9 years ago
I guess this is the way XBMC handles launching external applications. I can't 
imagine that I have control about this behaviour. But I will check.

Original comment by maloep on 28 Jul 2011 at 10:57

GoogleCodeExporter commented 9 years ago
This can be solved using Python subprocess module which is cross-platform 
compatible.

I have modified the function launchNonXbox in launcher.py file like this:

remove this line:
os.system(cmd.encode(sys.getfilesystemencoding()))

with this:
subprocess.Popen(cmd.encode(sys.getfilesystemencoding())

and works fine!

This function also supports paths with whitespaces so you don't need to add 
"call" to "cmd" string in windows anymore.

Original comment by isidro...@gmail.com on 23 Feb 2012 at 10:44

GoogleCodeExporter commented 9 years ago
Hello,

doesn't work for me, give the error : error launching emu : global name 
"subprocess" not defined

Original comment by franck.g...@gmail.com on 5 Mar 2012 at 3:57

GoogleCodeExporter commented 9 years ago
Opps!! I forgot a detail. You must add:

import subprocess

at beggining of file to include the subprocess module.

Original comment by isidro...@gmail.com on 14 Mar 2012 at 8:04

GoogleCodeExporter commented 9 years ago
Added in version 1.0.5. Sorry for the delay:)

Original comment by maloep on 4 Jul 2012 at 3:26