Make `fromString` work with all numbers, add `integerFromString`

samhh / fp-ts-std

The missing pseudo-standard library for fp-ts.

https://samhh.github.io/fp-ts-std/

MIT License

207 stars 27 forks source link

Closed imhoffd closed 1 year ago

imhoffd commented 1 year ago

Resolves #196

I added @since 0.18.0 tags for the new methods, let me know if that's the right approach.

When I ran yarn docs-ts, it seemed to delete a few code blocks from each generated file. I left those changes out, but please advise.

Also, I noticed this is the first time something may be deprecated in this library. I followed the way fp-ts deprecates things.

Hope I didn't miss anything. Thanks!

imhoffd commented 1 year ago

Makes sense! I wasn't sure if the change in behavior in fromString would be considered a breaking change.

I've applied the suggestions!

(I hope you squash PRs 😅)

samhh commented 1 year ago

Thanks! I expect to publish 0.18.0 including this sometime this week. 🙂