search

samhocevar / emoji.wpf

😸 Emoji support for WPF
Do What The F*ck You Want To Public License
369 stars 43 forks source link

Black doesn't render for multiple flags #77

Open janbuijs91 opened 6 months ago

janbuijs91 commented 6 months ago

I'm not seeing the black color in multiple flags, like Germany or Belgium. Here's a screenshot of how Germany is showing up for me: image

Looking at the source code for the flags, the Brush property isn't defined for some GeometryDrawing lines in multiple flags and I guess it should show up as black in that case, but for me it just doesn't show anything.

PsychoDad9999 commented 6 months ago

I had the same issue a while ago and added PR https://github.com/samhocevar/emoji.wpf/pull/73 to fix the german flag. I didn't noticed other flags were affected too.

janbuijs91 commented 6 months ago

Okay thanks for the reply. Guess I'll just clone the repo and add a brush to all GeometryDrawing elements which don't have a brush assigned. Any reason why you used #383838 instead of black?

PsychoDad9999 commented 6 months ago

Sounds good. #383838 is used in Win10Flags.xaml, thats the reason why I used that instead of black.