samhocevar / lolremez

📈 Polynomial Approximations using the Remez Algorithm
Do What The F*ck You Want To Public License
396 stars 36 forks source link

Problem with compilation in Mac OS #7

Closed MaxGraey closed 4 years ago

MaxGraey commented 6 years ago

Actually errors occur in make stage: First:

In file included from ./lol/algorithm/all.h:13:
./lol/algorithm/sort.h:56:54: error: call to 'max' is ambiguous
        for (ptrdiff_t i = 0; i < count_s() - 1; i = lol::max(i + d, (ptrdiff_t)0))
                                                     ^~~~~~~~

Second:

In file included from ./lol/math/all.h:22:
./lol/math/arraynd.h:80:18: error: call to 'max' is ambiguous
        *sizes = max(*sizes, (ptrdiff_t)m_initializers.size());
                 ^~~

Third:

In file included from ./lol/math/all.h:22:
./lol/math/arraynd.h:48:18: error: call to 'max' is ambiguous
        *sizes = max(*sizes, (ptrdiff_t)m_initializers.size());
                 ^~~
samhocevar commented 4 years ago

Hi! Sorry if you lost interest in this issue after all that time, but I could finally try to build lolremez on OS X and I can tell you that this build issue was actually fixed a long time ago, probably in e9567a8ebe.