search

samhowes / rules_msbuild

Build .csproj files with Bazel
Apache License 2.0
6 stars 3 forks source link

Features/m1 support #207

Open christopherschwaab opened 2 years ago

christopherschwaab commented 2 years ago

Thanks very much for this great project! Please excuse me for taking so long to get these changes into proper shape. I think this should fix the issue on new apple machines #206 and allow users to control the installer shas as they change rather than disabling them wholesale.

samhowes commented 2 years ago

My apologies, I'm far behind on attending to this project since I've transitioned to a new job.

The Azure pipelines builds are failing because I was lazy when I implemented the CI jobs, and just relied on version = "host", to rely on the already installed version of dotnet on the machine. I was also lazy when looking for package overrides in the installed versions.

I started addressing this over in: https://github.com/samhowes/rules_msbuild/pull/208 but haven't been able to devote much time to it recently.

Feel free to contribute to that PR, create a new PR that fixes the build definitions, or other fixes. I really appreciate your contributions and I am glad that my project has found some use. I'd like for it to continue to gain value.