samhowes / rules_msbuild

Build .csproj files with Bazel
Apache License 2.0
6 stars 3 forks source link

Error in fail: cannot use dotnet version 7.0.101; dotnet 6 is required for rules_msbuild. #210

Open oakad opened 1 year ago

oakad commented 1 year ago

rules_msbuild complain about dotnet core being too new. However, these days the releases happen rather often.

May it be possible to relax the strict version dependency a little?

It also appears, that there's some sort of overly strict dependency inference. My code targets "net6.0". My dotnet version is 7.0.101, as evident from the error message.

However, if I try to suppress the dotnet version check in sdk.bzl, I get the following error:

Error in fail: Tfm net7.0 was not configured for restore by nuget. If this was not a mistake, please add it to your nuget_fetch rule.

Clearly, I'm not trying to use the non-existent yet "net7.0" target. Yet, rules_msbuild somehow decide I need it.

Looks like default_tfm method is not future proof in its current form. To my opinion it should not infer anything and should rely on explicit user configuration.