sami79031 / LoopholeFunctionsTesting

0 stars 1 forks source link

Sign up with Apple -- name fields are empty after sign up. #15

Open katiahristova opened 11 months ago

sami79031 commented 11 months ago

@katiahristova I tested it out and it did happen to me one time but it was not because of the Apple sign up. The Apple sign up works just fine. The part that fails intermittently is when the load user API is called. It fails as other APIs had the same problem and were fixed with the retry logic.

katiahristova commented 11 months ago

@sami79031 This has been designated as top priority as there are now over 20 new users signed up without names in the past few days. John says it keeps happening when people click Continue with Apple/Google from the Log In screen. I already asked you about this and you said the flow is exactly the same from the Sign up and Log in screen, for these types of sign up. Could you please check again? If the issue is the fetch user methods, please implement the approach where we call it again if it returns empty. They need this somehow improved/resolved.

sami79031 commented 11 months ago

@katiahristova I made retry logic for this as well.

katiahristova commented 11 months ago

@sami79031 Two questions:

  1. How many hours?
  2. Please confirm again that there's no difference in the logic if you click the Google/Apple button from Log In or from Sign Up screen. The retry logic will work in both cases, right?
sami79031 commented 11 months ago

@katiahristova 1h in total and yes, there is no difference in the implementation