sami79031 / LoopholeFunctionsTesting

0 stars 1 forks source link

Recently watched query in Activity screen #6

Closed katiahristova closed 12 months ago

katiahristova commented 1 year ago

Tom would like us to try the query twice thing in Recently watched section on the Activity screen. If the data doesn't load the second time he would like the app to remain on the same screen and a banner or popup to show up saying: We're having trouble accessing your data right now.

There's one complication though -- they told me on the phone today that this particular part of the app is cached in an SQLite database to optimize the performance. So I'm thinking it won't be a simple thing to run the query twice, as really it's the SQLite database that's pulling the data and in the code we just query the SQLite database. What do you think? Please take a look and comment with hours or just do it if possible.

I suspected the caching thing because sometimes I see my recently watched movies flash, then 2 seconds later it disappears and I get "You have no recent activity" text there. This is the caching showing the old data and then obviously the refresh query returns empty and updates the screen.

sami79031 commented 1 year ago

The retry logic will be done. Not sure how I will propagate the error message since the logic is absolutely agnostic of the view and the connection happens through notifications. Not the best approach but this is what we have and refactoring will be costly and equal to rewriting a big fraction of the app.

However, there is a bigger problem that I'm facing at the moment. There is a logic bug that I'm trying to trace.

Try the following:

  1. Make sure the app is logged out
  2. Restart the app - this is important
  3. Log in to the app

Expected: All feed should be loaded Actual : Nothing gets loaded