search

samiamwork / Movist

Movie Player for Mac OS X based on QuickTime & FFmpeg. (Fork of original project on Google Code as it seems to have died)
GNU General Public License v3.0
206 stars 54 forks source link

external subtitle language or filename identification in the subtitle menu #3

Open ghost opened 13 years ago

ghost commented 13 years ago

there's an option in the advanced settings in preferences, to identify the subtitle's language codes (en, pt, it, es...) but it only applies to embedded subtitles.

it would be nice if it could read those codes out of the filename (could be between brackets or parenthesis): moviename [en].srt, moviename (pt).srt

and show the languages in the subtitle menu like: english, portuguese instead of subtitle 1, subtitle 2

alternatively, it could simply just show the actual .srt filenames in the menu: moviename (en).srt, moviename (pt).srt.

samiamwork commented 13 years ago

Guessing based on filename is problematic. I feel like guessing wrong is worse than not guessing at all (not always but, in this case I think it's true). Using the filename is pretty foolproof so I think that's a good way to handle it. Thanks a ton for filing the bug! =)

ghost commented 13 years ago

no, thank you!

ghost commented 13 years ago

samiamwork, i reopened this because i just looked at movist's control panel.

when you open it and there's an external subtitle, it always says 'unknown language'. now, you say guessing on the filename could be problematic but it already detects the language on an embedded .srt subtitle within a .mkv file, for example.

just out of curiosity, what's the difference if they're both .srt files? is it right to assume that the language is identified in the actual .mkv video header and not in the .srt file within it?

samiamwork commented 13 years ago

You didn't have to close the bug before anyway. While auto-detection of language may be problematic the request to put the filename in the menu is totally legit.

As for knowing the language for subtitles embedded in MKVs, I believe the MKV has metadata that says what language the embedded subtitle is in. I don't have the code in front of me so I can't be totally sure. Now it is totally possible to auto-detect the language of a subtitle based on the contents, but I'm not quite convinced that it'll be good enough (I've run into enough problems with auto-detect myself that I'm wary of leaning on it). That's not to say that it's not a good idea but I think it would require some careful work. In the meantime, using the filename shouldn't be too hard (of course I say that without looking at the code).

ghost commented 13 years ago

thanks again samiam, the filename option is the way to go. just wondering if the code could be already present but not applied to external subtitles.