Epic 7/story adapt design updates 77 applied state pattern

samiha-rahman / soen390

2 stars 0 forks source link

Epic 7/story adapt design updates 77 applied state pattern #80

Closed a-paggabao closed 4 years ago

a-paggabao commented 4 years ago

Adapt state pattern for Google Maps, floor-plan component and routes.
Combine displaying of maps and their associated routes, if any.

paulMoose commented 4 years ago

The build is failing:

HeadlessChrome 80.0.3987 (Linux 0.0.0) RouteCoordinatorService should be created FAILED NullInjectorError: StaticInjectorError(DynamicTestModule)[IndoorRouteBuilder]: StaticInjectorError(Platform: core)[IndoorRouteBuilder]: NullInjectorError: No provider for IndoorRouteBuilder!

Can you fix the failing tests please.

a-paggabao commented 4 years ago

Please fix failing unit tests and add some more unit tests for the code added.

Done. Refer to commit 546f504

a-paggabao commented 4 years ago

Small understanding questions left in the code. Should we clean up the old pages in this branch or after this is merged?

Done. Refer to commit 59260f4