search

samikeijonen / checathlon

Business type of theme with pixel perfect design
https://foxland.fi/downloads/checathlon/
8 stars 4 forks source link

Translating excerpt more #10

Closed justintadlock closed 7 years ago

justintadlock commented 7 years ago

In inc/functions-filters.php, the excerpt more filter is a bit odd at first glance:

/* Translators: The %s is mark after excerpt. */
$more = sprintf( esc_attr__( '%s', 'checathlon' ), '…' );

The %s itself can't be translated. However, I suppose a translator could simply use different text or add text next to the %s. I like to add the … inside of the translation so that it can be changed.

I wanted to bring this up to get your thoughts and make sure it was intentional.

samikeijonen commented 7 years ago

That does feel weird. Will update to have it like esc_attr__( '…', 'checathlon' ).

samikeijonen commented 7 years ago

@justintadlock was this what you ment: 8e4680c98222f31ed5e2a5a28556c277a9a3e3f2.

justintadlock commented 7 years ago

Yes, that's it.

Also, that should use esc_html rather than esc_attr. Just picked up on that.

samikeijonen commented 7 years ago

I'll change it tomorrow. Bed time around here.

On Dec 2, 2016 22:37, "Justin Tadlock" notifications@github.com wrote:

Yes, that's it.

Also, that should use esc_html rather than esc_attr. Just picked up on that.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/samikeijonen/checathlon/issues/10#issuecomment-264556452, or mute the thread https://github.com/notifications/unsubscribe-auth/ABvG_9uKhivkHTJUi2YW4ZCx917XzgT6ks5rEIF4gaJpZM4LB6gA .

samikeijonen commented 7 years ago

Changed in commit 05fd922ecd190a5c654cbd8899c6d46321ac40e3.