search

samikeijonen / checathlon

Business type of theme with pixel perfect design
https://foxland.fi/downloads/checathlon/
8 stars 4 forks source link

Sidebar IDs #11

Open justintadlock opened 7 years ago

justintadlock commented 7 years ago

I know it's a recommendation on WordPress.com, but I dislike naming sidebar IDs like sidebar-1, sidebar-2, and so on. It's OK with 3 or 4 sidebars, but when you've got 10 sidebars, it gets a bit confusing to follow in the code. Named sidebars like downloads or sidebar-downloads is far easier to catch onto quickly.

Anyway, this is just purely a different developer perspective that I thought I'd throw out there.

samikeijonen commented 7 years ago

Yeah it was originally for wp.com but theme was not approved in there. So might name them more sane way.

On Dec 2, 2016 23:11, "Justin Tadlock" notifications@github.com wrote:

I know it's a recommendation on WordPress.com, but I dislike naming sidebar IDs like sidebar-1, sidebar-2, and so on. It's OK with 3 or 4 sidebars, but when you've got 10 sidebars, it gets a bit confusing to follow in the code. Named sidebars like downloads or sidebar-downloads is far easier to catch onto quickly.

Anyway, this is just purely a different developer perspective that I thought I'd throw out there.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/samikeijonen/checathlon/issues/11, or mute the thread https://github.com/notifications/unsubscribe-auth/ABvG_-SHjhjG2b_lBj9FI7Oqt4DxAow1ks5rEIlugaJpZM4LC_lk .

justintadlock commented 7 years ago

Not approved on .COM? That's crazy to me. :)

samikeijonen commented 7 years ago

Yeah same old story. Not good enough design and our users brobably don't like it.

On Dec 2, 2016 11:17 PM, "Justin Tadlock" notifications@github.com wrote:

Not approved on .COM? That's crazy to me. :)

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/samikeijonen/checathlon/issues/11#issuecomment-264564944, or mute the thread https://github.com/notifications/unsubscribe-auth/ABvG_xEHIzuM5-l3_ysMsewkQiMafQHoks5rEIrwgaJpZM4LC_lk .