samikeijonen / mina-olen

Mina olen WordPress Theme
https://foxland.fi/downloads/mina-olen/
13 stars 2 forks source link

Jetpack portfolio - Testimonials support for Callout #7

Open fxbenard opened 9 years ago

samikeijonen commented 9 years ago

Was this reminder to add support for Jetpack portfolio and testimonials?

Front page support can be tricky but other basic support will be easier to add.

fxbenard commented 9 years ago

Yes it is, if you use them, portfolios don't shows up on frontpage. Only the area title. After they work every else. See by yourself https://demos.hexagone.io/mina-olen/

samikeijonen commented 9 years ago

One reason for this is that every plugin author have different types of slugs for same post type. It would be cool if people were actually using content type standards.

https://github.com/justintadlock/content-type-standards

Now we need to add if - else checks for different plugins if we want to support them in page templates. Archives always works and fallback for index.php.

fxbenard commented 9 years ago

Ok great I will not push users to use jetpack but Custom Content Portfolio even if @justintadlock didn't updated it for more than 2 years ;) But you're right if you start using if - else checks you'll never ed up adding new rules

samikeijonen commented 9 years ago

I'm gonna check tomorrow is there an easy way to add Jetpack support for Portfolio and Testimonials.

fxbenard commented 9 years ago

Great, Jetpack might be someday kind of standard for portfolio and testimonials cpt

samikeijonen commented 9 years ago

Yeah but not for post type names. They use jetpack prefix in post type names. Not so good:)

justintadlock commented 9 years ago

I'm in the process of updating CCP to support the custom post type standards project. We should reach out to portfolio plugin developers about supporting it or getting us all together and making an uber-portfolio plugin.

samikeijonen commented 9 years ago

Thanks @justintadlock for comment. Looking forward to that update.

fxbenard commented 9 years ago

great news, we'll definitely wait for this update. @samikeijonen no rush ;)