samirkumardas / jmuxer

jMuxer - a simple javascript mp4 muxer that works in both browser and node environment.
Other
559 stars 114 forks source link

Fix audio issue when using multiple jmuxer instances on the same page. #108

Closed etenoch closed 2 years ago

etenoch commented 2 years ago

When using multiple jmuxer instances with audio enabled on the same page, we notice errors being thrown (below). The AACParser was being shared amongst al instances and the headers were being stored globally.

Also built minified and non-minified copies manually. I did not update the build script or rollup config, i just built the non-minified using npm run build, then renamed the file from jmuxer.min.js to jmuxer.js. jmuxer.min.js was built regularly using npm run pro.

image
samirkumardas commented 2 years ago

Thank you for your afford and time. I will look into this weekend.

samirkumardas commented 2 years ago

looks good. Thank you.