search

samiskin / redux-electron-store

⎋ A redux store enhancer that allows automatic synchronization between electron processes
MIT License
375 stars 32 forks source link

Consider using individual lodash modules #20

Closed davej closed 8 years ago

davej commented 8 years ago

I wonder would you consider requiring the individual lodash modules instead of doing a catch-all import.

// Instead of this:
import _ from 'lodash';

// You could do this:
import cloneDeep from 'lodash/cloneDeep';

I'm on a mission to trim down my electron app and improve boot time, lodash is one of the prime offenders, see screenshot below.

image

samiskin commented 8 years ago

Sure, I'll get it done within the next couple days :+1:

anaisbetts commented 8 years ago

@samiskin Don't do it yourself, make @davej submit a PR :)

anaisbetts commented 8 years ago

Never fix bugs in open-source projects when you can be teaching the reporter how to submit a PR instead

samiskin commented 8 years ago

Ah makes sense. Well then, @davej could you submit a PR for it? 😄

davej commented 8 years ago

Haha, sure, I'm on it now :)

davej commented 8 years ago

Ok, should be good to go. Did some brief manual testing on my app and all seems to be well. The package is also super-light now. :)