search

samiskin / redux-electron-store

⎋ A redux store enhancer that allows automatic synchronization between electron processes
MIT License
375 stars 32 forks source link

Refactor to typescript #69

Open sneljo1 opened 4 years ago

sneljo1 commented 4 years ago

I have converted the project to typescript, to increase the maintainability with breaking changes in electron. And also to provide types for typescript projects. During this refactor, I have also taken the liberty to write test cases for some of the possible options. Which led me to see that #68 is not possible. The functionality has been removed in this PR. Unless you have an other suggestion, I would remove it, since it does not work. Implementing something that doesn't send functions through IPC will be more work for sure. I have also updated to README since I thought that needed some love to.

What do you think?

ttay24 commented 2 years ago

@Superjo149 this PR seems great. I would assume at this point that it probably won't be merged. Do you have any plans on publishing the fork you've created, or are you not really using this library anymore?

samiskin commented 2 years ago

@ttay24 I abandoned this project a while back, and it'd require further updates to function now in Electron 14 and up due to the removal of remote. You likely want to check out https://github.com/klarna/electron-redux/tree/alpha , its basically the same idea as this library.

If something about how this library is set up makes you want a working typed version of this this over that, I might be willing to update this one since there'd be some value there.