samizdatco / skia-canvas

A GPU-accelerated 2D graphics environment for Node.js
MIT License
1.7k stars 66 forks source link

Problem with DOMMatrix polyfill ? #129

Open renambot opened 1 year ago

renambot commented 1 year ago

Wondering if there's a bug in the toSkMatrix function. I think maybe if (jsMatrix instanceof geometry.DOMMatrix) should be if (jsMatrix instanceof DOMMatrix)

I'm rendering a PDF file (with PDFjs lib) using skia-canvas and it works fine, except sometimes it crashes in toSkMatrix function, because there's no 'true' path in the tests. If I update with jsMatrix instanceof DOMMatrix it works fine.