samjabrahams / tensorflow-on-raspberry-pi

TensorFlow for Raspberry Pi
Other
2.24k stars 496 forks source link

Replacing Eigen value #129

Open ghost opened 6 years ago

ghost commented 6 years ago

Describe the Issue

This section of code is longer present in tensorflow/workspace.bzl. When replacing the Eigen dependency it's unclear if I am supposed to move on to the next step or if something needs to be updated.

Missing code snippet from workspace.bzl

native.new_http_archive(
      name = "eigen_archive",
      urls = [
          "http://mirror.bazel.build/bitbucket.org/eigen/eigen/get/f3a22f35b044.tar.gz",
          "https://bitbucket.org/eigen/eigen/get/f3a22f35b044.tar.gz",
      ],
      sha256 = "ca7beac153d4059c02c8fc59816c82d54ea47fe58365e8aded4082ded0b820c4",
      strip_prefix = "eigen-eigen-f3a22f35b044",
      build_file = str(Label("//third_party:eigen.BUILD")),
  )
yconst commented 6 years ago

It seems there is a slight change in newer tf versions. I searched for "eigen" and found the updated section as follows:

tf_http_archive(
      name = "eigen_archive",
      urls = [
          "http://mirror.bazel.build/bitbucket.org/eigen/eigen/get/d781c1de9834.tar.gz",
          "https://bitbucket.org/eigen/eigen/get/d781c1de9834.tar.gz",
      ],
      sha256 = "a34b208da6ec18fa8da963369e166e4a368612c14d956dd2f9d7072904675d9b",
      strip_prefix = "eigen-eigen-d781c1de9834",
      build_file = str(Label("//third_party:eigen.BUILD")),
  )
anandsaini024 commented 6 years ago

@yconst Does the code work as it is? or do we need to edit and add this piece of code?

ghost commented 6 years ago

I wasn't able to get it to work as it is

On Fri, Feb 23, 2018, 11:09 AM Anand Saini notifications@github.com wrote:

@yconst https://github.com/yconst Does the code work as it is? or do we need to edit and add this piece of code?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/samjabrahams/tensorflow-on-raspberry-pi/issues/129#issuecomment-368108960, or mute the thread https://github.com/notifications/unsubscribe-auth/AIBDxSgK6qsQ6wpc0SLf4i_VCn6eAcz8ks5tXwzggaJpZM4RnUZ1 .

yconst commented 6 years ago

I got it to compile by replacing the mentioned section with whats mentioned in the tutorial.

ghost commented 6 years ago

Maybe I'll retry from scratch then.

On Fri, Feb 23, 2018, 4:38 PM Yannis notifications@github.com wrote:

I got it to compile by replacing the mentioned section with whats mentioned in the tutorial.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/samjabrahams/tensorflow-on-raspberry-pi/issues/129#issuecomment-368179291, or mute the thread https://github.com/notifications/unsubscribe-auth/AIBDxSfNA7g4PhYG--JrKo514mSjoarIks5tX1nsgaJpZM4RnUZ1 .