search

samjmck / tobcalc

Web app that calculates the Belgian transaction tax from foreign brokers and fills in the tax declaration PDF
https://tobcalc.com
GNU Affero General Public License v3.0
59 stars 18 forks source link

Improve UI #24

Closed bhanquet closed 4 months ago

bhanquet commented 5 months ago

I've done quite a few changes in the UI I hope that's OK. I tried to have something more pleasing for the users. First I changed the structure in the components folder to have something like this:

├── BrokerAdapter.svelte
├── Brokers.svelte
├── Header.svelte
├── icon
│   ├── Close.svelte
│   └── Setting.svelte
├── modal
│   ├── Modal.svelte
│   ├── PaymentInfo.svelte
│   ├── PromptFailedSecurityFetches.svelte
│   ├── PromptFilterBrokerTransactions.svelte
│   ├── PromptMergeTransactions.svelte
│   └── Settings.svelte
├── PdfDownload.svelte
├── PersonalInfo.svelte
├── TaxRateOverride.svelte
└── ui
    ├── Button.svelte
    ├── Input.svelte
    ├── QrCode.svelte
    ├── Select.svelte
    └── Table.svelte

I added button, input, select, table and modal components. I added a header. I also moved the button to open the setting dialog in the header instead of the footer.

netlify[bot] commented 5 months ago

Deploy Preview for tobcalc ready!

Name Link
Latest commit 290ebbaa4c652c3fd24e6ada3de052124ff2d202
Latest deploy log https://app.netlify.com/sites/tobcalc/deploys/661af883224aa9000852d952
Deploy Preview https://deploy-preview-24--tobcalc.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

samjmck commented 4 months ago

At first glance this looks good! I will review it soon. Apologies for the delay, have been very busy recently.

bhanquet commented 4 months ago

No problem take your time 😉