Closed samjmolyneux closed 2 months ago
we will need to completely change the graphing for this to work because when the ticks do not include the line it wont show up there
I think that maybe the way that we get it working for the log case is that we can use some sort of transformation to get the threshold to be zero. I think that this should look something like including the base_value back into the function (add the explainer.expected_value to the cum_sums) and then minus the threshold from all of them.
Focus on trying to sort the original method first. Then afterward check to see if a log around threshold is likely to be necessary, because if anything I imagine that its more necessary around the expected value in terms of seeing the changes (although probably not necessary in seeing what pushes things over the edge)
Or just get the threshold line in the correct place