search

samjmolyneux / eppi-text-classification

Classifying papers by their abstracts and titles.
2 stars 0 forks source link

Change middle line for decision plot, so that the threshold line is in the middle #27

Closed samjmolyneux closed 2 months ago

samjmolyneux commented 2 months ago

Or just get the threshold line in the correct place

samjmolyneux commented 2 months ago

we will need to completely change the graphing for this to work because when the ticks do not include the line it wont show up there

samjmolyneux commented 2 months ago

I think that maybe the way that we get it working for the log case is that we can use some sort of transformation to get the threshold to be zero. I think that this should look something like including the base_value back into the function (add the explainer.expected_value to the cum_sums) and then minus the threshold from all of them.

samjmolyneux commented 2 months ago

Focus on trying to sort the original method first. Then afterward check to see if a log around threshold is likely to be necessary, because if anything I imagine that its more necessary around the expected value in terms of seeing the changes (although probably not necessary in seeing what pushes things over the edge)